Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x: Fix excess item retention in the other replay components #5898

Merged
merged 1 commit into from
Mar 7, 2018
Merged

2.x: Fix excess item retention in the other replay components #5898

merged 1 commit into from
Mar 7, 2018

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Mar 7, 2018

This is a follow-up PR to #5892 in order to avoid item retention in the head node. For the ReplayProcessor, the cleanup can be triggered with cleanupBuffer. For the replay() operators, such trigger is not possible. However, the terminal events will perform the cleanup internally at least.

@akarnokd akarnokd added this to the 2.2 milestone Mar 7, 2018
@codecov
Copy link

codecov bot commented Mar 7, 2018

Codecov Report

Merging #5898 into 2.x will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5898      +/-   ##
============================================
+ Coverage     97.92%   97.96%   +0.04%     
- Complexity     5984     5988       +4     
============================================
  Files           655      655              
  Lines         43863    43899      +36     
  Branches       6076     6082       +6     
============================================
+ Hits          42953    43007      +54     
+ Misses          281      274       -7     
+ Partials        629      618      -11
Impacted Files Coverage Δ Complexity Δ
...ex/internal/operators/flowable/FlowableReplay.java 92.79% <100%> (+0.1%) 22 <0> (ø) ⬇️
.../java/io/reactivex/processors/ReplayProcessor.java 99.38% <100%> (+0.02%) 52 <1> (+1) ⬆️
...nternal/operators/observable/ObservableReplay.java 98.63% <100%> (+0.02%) 23 <0> (ø) ⬇️
.../io/reactivex/internal/functions/ObjectHelper.java 94.73% <0%> (-5.27%) 20% <0%> (-1%)
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0%> (-3.97%) 2% <0%> (ø)
...tivex/internal/schedulers/TrampolineScheduler.java 96.1% <0%> (-2.6%) 6% <0%> (ø)
...java/io/reactivex/processors/PublishProcessor.java 98.23% <0%> (-1.77%) 43% <0%> (-1%)
...x/internal/operators/flowable/FlowablePublish.java 96.03% <0%> (-1.33%) 11% <0%> (ø)
...rnal/operators/flowable/FlowableSequenceEqual.java 97.56% <0%> (-1.22%) 2% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-1.2%) 2% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2edea6b...cefaade. Read the comment docs.

@akarnokd akarnokd merged commit 5e5d5a2 into ReactiveX:2.x Mar 7, 2018
@akarnokd akarnokd deleted the ReplayProcessorNCoRetentionFix branch March 7, 2018 17:49
@akarnokd akarnokd mentioned this pull request Mar 15, 2018
Closed
This was referenced Mar 20, 2018
Closed
Closed
@jared-bot jared-bot mentioned this pull request May 8, 2018
Merged
@akarnokd akarnokd mentioned this pull request May 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanniktech vanniktech vanniktech approved these changes

Assignees
No one assigned
Labels
2.x Shortcoming
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@akarnokd @vanniktech